tests/production/flat-polygon/vite.config.ts (2)

12-15: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Hardcoded node_modules nesting path is fragile to pnpm hoisting changes.

packages/layers/node_modules/@deck.gl/core/dist/index.js assumes a specific pnpm dependency-resolution layout. If hoisting behavior or the pinned @deck.gl/core version changes, this path silently breaks the build with an opaque resolution error.

♻️ Suggested resolution via require.resolve

-const deckCoreRoot = path.join(
-  workspaceRoot,
-  'packages/layers/node_modules/@deck.gl/core/dist/index.js'
-);
+const deckCoreRoot = require.resolve('`@deck.gl/core`', { paths: [path.join(workspaceRoot, 'packages/layers')] });

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/production/flat-polygon/vite.config.ts` around lines 12 - 15, Replace
the hardcoded `@deck.gl/core` node_modules path used by deckCoreRoot with
module-resolution logic based on require.resolve, so the configuration locates
the installed package entry point regardless of pnpm hoisting or dependency
layout.

---

51-75: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Alias replacements point at single files, not package roots — subpath imports would resolve incorrectly.

Vite/rollup-plugin-alias matches ids that start with find + '/' too, but these replacements are exact dist/index.js file paths. A future @spatialdata/core/<subpath> import would resolve to <...>/index.js/<subpath>, which doesn't exist. Not currently triggered by any import in this diff, but worth a defensive note for future maintainers of this consumer harness.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/production/flat-polygon/vite.config.ts` around lines 51 - 75, Update
the alias replacements for the package-root aliases in the Vite configuration so
subpath imports resolve beneath each package’s dist root rather than beneath a
file path. Preserve the dedicated worker alias and existing external dependency
aliases, and ensure the affected `@spatialdata` and zarrextra package aliases
still resolve their main entry points.

tests/production/flat-polygon/smoke.spec.ts (1)

20-38: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Ordering-dependent 404/console-error correlation risks flaky failures.

Gating allowedMetadataConsoleErrors against expectedMetadata404Count at event-arrival time assumes the response event for a given 404 always arrives before its corresponding console error. That ordering isn't guaranteed across CDP event delivery, so a console error legitimately caused by an expected 404 could still fail the test if it's processed first.

♻️ Suggested fix: compare aggregate counts after collection instead of gating live

   page.on('console', (message) => {
     if (message.type() !== 'error') return;
-    if (
-      expectedMetadataConsoleError.test(message.text()) &&
-      allowedMetadataConsoleErrors < expectedMetadata404Count
-    ) {
-      allowedMetadataConsoleErrors += 1;
-      return;
-    }
-    consoleErrors.push(message.text());
+    if (expectedMetadataConsoleError.test(message.text())) {
+      allowedMetadataConsoleErrors += 1;
+      return;
+    }
+    consoleErrors.push(message.text());
   });

And after the page interactions complete:

+  expect(allowedMetadataConsoleErrors).toBeLessThanOrEqual(expectedMetadata404Count);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/production/flat-polygon/smoke.spec.ts` around lines 20 - 38, Update the
response and console event handlers in the smoke test to collect expected 404
and matching console-error counts independently, without gating
allowedMetadataConsoleErrors against expectedMetadata404Count during event
arrival. After page interactions complete, compare aggregate counts and exclude
only the number of expected metadata console errors that can be matched to
expected 404 responses, while preserving unexpected 404 URL and remaining
console-error reporting.

test-results/.last-run.json (1)

1-4: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Remove committed Playwright artifact; deferred to consolidated comment.
See the consolidated comment covering this file and test-fixtures.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test-results/.last-run.json` around lines 1 - 4, Remove the committed
Playwright artifact represented by .last-run.json from version control, ensuring
generated test-result files are not included in the change.

packages/layers/src/FlatPolygonLayer.ts (1)

107-114: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low value

Add coverage for the model recreation branch or track the initial creation more robustly.

This code prevents destroying the model on the first extensionsChanged update from Deck, but packages/layers/tests/flatPolygonLayer.spec.ts only tests _getModel() passes Deck’s shaderAssembler; it has no cases for the first post-initializeState update or a later real extensions change.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/layers/src/FlatPolygonLayer.ts` around lines 107 - 114, Add tests in
flatPolygonLayer.spec.ts covering updateState after initializeState with
extensionsChanged and no oldProps.extensions, asserting the existing model is
retained, plus a later genuine extensions change with oldProps.extensions
defined, asserting the model is destroyed and recreated. Reuse the existing
_getModel/shaderAssembler test setup and target the updateState model-recreation
branch.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes